You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The reason will be displayed to describe this comment to others. Learn more.
I'm wondering if this should be in the Reset() function instead. But I think this might be more correct, the wakelock should release on the transition from ringing <10s to >10s, and also from ringing <10s to stopped / reset.
I'm still not really sure if it should go in Reset() or not. There were a few reasons I put it where it is. First was so that it was very clear what is happening, second was to save unnecessarily releasing the wakelock when other functions call Reset() but the release is not strictly required, and the third was that I didn't spot any refactoring that would result in a reduction in program size to move it to Reset().
Happy to move to Reset() if my thought process is flawed/not a good design etc.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2419
Tested on watch hardware