Bugfix timer stopping buzzing when 10 seconds haven't passed

[Thulium-Drake]

Hi there!

Another thing my GF noticed when using the timer app, it buzzes twice and then stops buzzing. And I've seen a lot of issues, PRs etc mentioning this (#2085 #391 and some others). But I when went looking in the source specifically because #1971 mentions it changed that the watch should keep buzzing for 10 seconds, but my tests in InfiniSim (as well as the experience from my GF) is that it buzzes twice and then stops.

So I have patched the logic to keep buzzing when it isn't buzzing already for 10 seconds.

NOTE: This does not fix the "receiving notifications cancels the timer" bug, as that event will cause the Timer app to exit, killing the buzz (literally ;-) )

[github-actions]

Build size and comparison to main:

Section	Size	Difference
text	385248B	16B
data	944B	0B
bss	22640B	0B

Run in InfiniEmu

[mark9064]

I can't reproduce this on my watch, though I'm not currently running base 1.16 (I'm pretty sure however there's nothing on the branch that changes timer behaviour though)

Could you provide reproduction steps?

[Thulium-Drake]

Well, it seems I was mistaken, after she mentioned it to me, I fired up InfiniSim and tried it in there and the indicator (the red bell) stopped blinking after 2 blinks. And with this patch it kept blinking up to the 10 seconds I expected.

And when I checked it on her watch yesterday (I was flashing a custom build of InfiniTime with my other PR for her) I also tested the alarm. And it does work. And to verify, I also just checked it in InfiniEmu, also not a problem.

Could this be a bug in InfiniSim then?

[mark9064]

Certainly sounds possible

@muesli as our new InfiniSim bug squashing expert, any thoughts :)