feat: compatible with Cub versions #105
Open
+33
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JYMiracle305
requested review from
Chamberlain0w0,
chen2021673 and
kilinchange
and removed request for
kilinchange
chen2021673
reviewed
Jan 29, 2026
| thread_max = fmaxf(thread_max, common::cuda::Cast<float>(input_ptr[base + i])); | ||
| } | ||
| const float block_max = cub::BlockReduce<float, BLOCK_SIZE>(shared.reduce).Reduce(thread_max, ::cuda::maximum<>()); | ||
| const float block_max = cub::BlockReduce<float, BLOCK_SIZE>(shared.reduce).Reduce(thread_max, CubSumOp()); |
Contributor
There was a problem hiding this comment.
这里为什么是 CubSumOp 不是 CubMaxOp 啊
Contributor
Author
There was a problem hiding this comment.
这里替换的时候替换错了，我改一下
JYMiracle305
force-pushed
the
feat/cub_compat
branch
from
5f01c4c to
69c29b7
Compare
Chamberlain0w0
approved these changes
Jan 29, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
为不同版本的 NVIDIA CUB 库提供统一的归约操作符（Sum/Max/Min等）类型别名，在 CUB 2.8.0 及以上版本使用 cuda::std 中的函数对象，旧版本则回退到传统的 cub:: 操作符，以屏蔽版本差异实现向后兼容。