Repository navigation
fix: resolve CI build dependencies, Iluvatar includes and Ascend SOC detection - #1007
Draft
baominghelly wants to merge 1 commit into
Draft
baominghelly wants to merge 1 commit into
baominghelly wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
scikit-build-core>=1.1.1, and usepython -m pipconsistently.npu-smimodel tokens. Reject numeric fields such as3103and request an explicitSOC_VERSIONwhen detection is ambiguous.Motivation
Follow-up to #1003. CI images can retain an older scikit-build-core when builds use
--no-build-isolation, causing thesdist.force-includeconfiguration to fail. Iluvatar dispatch compilation lacks header search paths, and the previous Ascend parser can interpret HBM statistics as a chip model.This draft runs the fixes through the real accelerator CI environments. Local validation does not establish that hardware builds or operator tests pass.
Type of Change
feat— new feature / new operator / new platformfix— bug fixperf— performance improvement (no behavioral change)refactor— code restructuring without behavior changetest— adding or fixing tests onlybuild/ci— build system or CI configurationchore— tooling, formatting, or other non-code changesPlatforms Affected
WITH_CPU)WITH_NVIDIA)WITH_ILUVATAR)WITH_METAX)WITH_CAMBRICON)WITH_MOORE)WITH_ASCEND)WITH_HYGON)WITH_TORCH)Smoke Test Result
Accelerator smoke builds/tests: Not run locally — this Windows host lacks the accelerator SDKs and hardware. CI is the required hardware validation.
Local regression validation (PowerShell, Python 3.13, scikit-build-core 1.1.1, CMake 4.4.4 and MinGW g++):
These tests generate wheel metadata with the real build backend, compile a minimal C++ translation unit with the actual Iluvatar include flags, and invoke the actual SOC CMake detector with simulated runtime/SMI outputs. They do not compile accelerator kernels.
--confcutdiravoids loading the operator test suite's torch/InfiniOps fixtures.Test Results on Supported Platforms
Benchmark / Performance Impact
N/A — build and CI fixes; no operator kernel changes.
Notes for Reviewers
Ascend3103.SOC_VERSION..h,.cc,.cuh,.mlu).