Skip to content

fix: stage icclrun wrappers for remote MPI launches #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Ziminli merged 2 commits into from
Aug 10, 2026
+8 −3
Merged

fix: stage icclrun wrappers for remote MPI launches #56

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5dd5e0d
fix: stage `icclrun` wrappers for remote MPI launches
Ziminli Aug 7, 2026
3ee7dee
style: ruff format `scripts/backends/mpi_base.py`
Ziminli Aug 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions scripts/backends/mpi_base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,9 +41,14 @@ def get_launch_command(self, config, executable, user_args, launcher_obj):
if not launcher_script:
launcher_script = launcher_obj.ensure_launcher_exists()

# If any node-specific `dir` is given, stage the generated wrapper at one identical '/tmp' path on all nodes.
# Node-specific dirs may differ, but 'mpirun' can launch only one script path.
if any("dir" in node for node in config["nodes"]):
# Stage generated wrappers when `mpirun` needs one executable path for
# node-specific source dirs, or when a remote node would otherwise exec
# the wrapper directly from shared storage such as NFS to avoid conflicts.
should_stage_launcher = any(
"dir" in node for node in config["nodes"]
) or any(not launcher_obj._is_local(node["ip"]) for node in config["nodes"])

if should_stage_launcher:
remote_launcher = f"/tmp/infiniccl_{os.path.basename(launcher_script)}"
subprocess.run(["cp", launcher_script, remote_launcher], check=True)
os.chmod(remote_launcher, 0o755)
Expand Down
Loading