Fixes PR #72 #6
Fixes PR #72 #6
Conversation
aybaof
force-pushed
the
git_revert_index_change
branch
2 times, most recently
from
e4284be to
45d92d1
Compare
fixes PR to squash prettier to squash config prettier vscode != cli
aybaof
force-pushed
the
git_revert_index_change
branch
from
45d92d1 to
39c7286
Compare
|
Fixes last pull request with integration of bootstrap / font correctly and rework of sidemenu using flex instead of table |
|
Could you remind me what the PR is doing and also post screenshots of the intended UI after this change?
This is what I see on my end, but I'm not entirely sure all the changes are expected. |
| /* #switch_week_button { | ||
| background-color: #2cb8f0; | ||
| color: white; | ||
| padding: 15px; | ||
| width: 15%; | ||
| height: 2%; | ||
| text-decoration: none; | ||
| text-align: center; | ||
| /* font-family: 'Billionary';*/ | ||
| vertical-align: middle; | ||
| font-size: 2rem; | ||
| } | ||
|
|
||
| .next-week-link { | ||
| background-color: #2cb8f0; | ||
| position: fixed; | ||
| right: 1.5%; | ||
| bottom: 0; | ||
| } | ||
|
|
||
| .this-week-link { | ||
| background-color: #e844f4; | ||
| position: fixed; | ||
| left: 0; | ||
| bottom: 0; | ||
| } | ||
| min-width: 300px; | ||
| } */ |
There was a problem hiding this comment.
Could we get rid of any comments of code? Comments are of course fine if they are describing some piece of code, but code that's commented out seem to not add any value and take up unnecessary space/complexity.
There was a problem hiding this comment.
Yes sorry its mainly left overs of old code.
Would it be ok to merge it for now , and i will make a commit afterwards removing all unnecessary comment in css later ?
There was a problem hiding this comment.
It looks like the comment was added in this PR, so it would be good to remove it here.
|
This PR is mainly about start including bootstrap theme on index, and rework some layout like the sidenav. |
It looks like there are changes to the UI from this PR though. Could you take a look at the screenshot I sent and lmk if that is intended? For example, the "next week" text on the top left is noticeably smaller. |
2 participants
No description provided.