Fixing the demo to not provoque ctrl actions with modded keyboards or mobile virtual keyboards #879
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While using a modded keyboard with macros on the characters pressing the keys affected by the ctrl modifier without ctrl down, would still trigger it, it was the same issue using the Android virtual keyboard.
Here's an example of what was happening, pressing
awould erase all text and write the letterainstead, pressingbwould write the letterbat the start of the text area and set the cursor in between the first and second character, pressingewould add the lettereat the end of the text area.After some code investigation, I found out that calling
nk_input_keywould always increasectx->input.keyboard.keys[key].clickedeven ifctrlwasn't push, then if it was released while the clicked counter was still equals to 1, it would increase it to 2 triggering thenk_input_key_presseddue to the validation ofif ((k->down && k->clicked) || (!k->down && k->clicked >= 2)).Only calling
nk_input_keywhenctrlis down fixes the problem.