Re-implementation nk_text_clamp for correct clamping logic#830
Draft
PavelSharp wants to merge 2 commits intoImmediate-Mode-UI:masterfrom
Draft
Re-implementation nk_text_clamp for correct clamping logic#830PavelSharp wants to merge 2 commits intoImmediate-Mode-UI:masterfrom
nk_text_clamp for correct clamping logic#830PavelSharp wants to merge 2 commits intoImmediate-Mode-UI:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refers to #828.
I am submitting this as a draft since additional testing with existing code is still required. From my perspective, the new implementation appears correct and reliable. Another key improvement is that
NULLpointer parameters are now handled gracefully, eliminating potential undefined behavior.I would appreciate feedback from reviewers, especially regarding edge cases or scenarios that I may have overlooked.
Before (For source code of example app please see #828)
After