refactor: migrate to StreamController event system#66
Merged
Conversation
ImDevinC
force-pushed
the
refactor/migrate-to-event-system
branch
4 times, most recently
from
2142f0a to
03dfd64
Compare
- Replace register_backend_callback with plugin_base.connect_to_event - Update callback signatures to use *args, **kwargs pattern - Remove custom callback management from backend.py - Add EventHolder registration for voice and channel events - Implement trigger_event method in main.py for event dispatching - Simplify backend by removing callbacks dict - Update version from 1.10.0 to 1.11.0
ImDevinC
force-pushed
the
refactor/migrate-to-event-system
branch
from
03dfd64 to
ae2febb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Migrates the plugin from a custom callback system to
StreamController's built-in EventHolder system for better
integration with the core framework.
Changes
plugin_base.connect_to_event across all action classes
(ChangeVoiceChannel, Deafen, Mute, TogglePTT, UserVolume)
(register_callback, unregister_callback) from backend.py
(VOICE_CHANNEL_SELECT, VOICE_SETTINGS_UPDATE, GET_CHANNEL)
dispatching through EventHolder system
Impact
This maintains the same external functionality while: