Skip to content

feat(angular): add chip variants#250

Open
onlyexeption wants to merge 3 commits into
masterfrom
ibarakov/angular-add-chip-variants
Open

feat(angular): add chip variants#250
onlyexeption wants to merge 3 commits into
masterfrom
ibarakov/angular-add-chip-variants

Conversation

@onlyexeption
Copy link
Copy Markdown
Contributor

No description provided.

@onlyexeption onlyexeption requested review from Copilot and kdinev May 28, 2026 10:29
@onlyexeption onlyexeption added 📖 documentation Improvements or additions to documentation ❌ status: awaiting-test PRs awaiting manual verification labels May 28, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds documentation for the new Angular Chip variant input, describing the supported stylistic variants and linking to a live sample.

Changes:

  • Introduces a new Variants section explaining how to set the Chip variant (primary, info, success, warning, danger).
  • Adds an HTML snippet demonstrating variant="success".
  • Embeds a new sample reference for chip variants.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +101 to +109
## Variants

The Angular chip supports several pre-defined stylistic variants. You can change the variant by assigning one of the supported values - `primary`, `info`, `success`, `warning`, or `danger` to the <ApiLink type="Chip" member="variant" label="variant" /> input property.

```html
<igx-chip variant="success">Success</igx-chip>
```

<Sample src="/data-display/chip-variants" height={100} alt="Angular Chip Variants Example" />
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added the equivalent Variants section to the Japanese chip docs at docs/angular/src/content/jp/components/chip.mdx.

kdinev
kdinev previously approved these changes May 28, 2026
simeonoff
simeonoff previously approved these changes May 28, 2026
@kdinev kdinev added ✅ status: verified Applies to PRs that have passed manual verification and removed ❌ status: awaiting-test PRs awaiting manual verification labels May 28, 2026
Copilot AI dismissed stale reviews from simeonoff and kdinev via 2a53cdd May 28, 2026 13:29
Copilot finished work on behalf of kdinev May 28, 2026 13:30
Copilot AI requested a review from kdinev May 28, 2026 13:30
@kdinev kdinev requested a review from norikois May 28, 2026 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

📖 documentation Improvements or additions to documentation ✅ status: verified Applies to PRs that have passed manual verification

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants