fix(xplat): prevent oversized rendering of images#247
Closed
Zneeky wants to merge 4 commits into
Closed
Conversation
The shared design system applies width:100% to every <img> inside .igd-main-content__markdown, which stretches portrait/small images to full content-column width and recomputes height from the intrinsic ratio - rendering the 378x597 Blazor card screenshot as a ~1420px tall tower. Adds an inline width:auto override on the four affected sites and a top-level docs/IMAGE_SIZING.md explaining the pattern for future contributors. Closes #245
Mirror the EN-side width:auto inline override on the four JP equivalents so the Blazor card screenshot renders at intrinsic size on the Japanese documentation as well.
…ages The 236x206 wc-project screenshot (web-components getting-started) and the 626x1107 layout_mode screenshot (chart data legend / tooltip pages) both hit the global width:100% rule and render way larger than their intrinsic size. Adds the same inline width:auto override on every EN/JP instance across xplat and angular.
Contributor
|
Closing in favour of #251 , which is adding the styles globally and intodusing separate component for the getting started buttons |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #245
Summary
igniteui-astro-componentsglobal rule.igd-main-content__markdown img { width: 100%; object-fit: cover; }stretches every image inside the article column to full width and
applies
object-fit: cover. For portrait or small-width screenshotsthis produces enormous renders — e.g. the 378×597 Blazor card image
becomes a ~1420px-tall tower.
style="width:auto;"on the four Blazor card<Image>sitesso they render at intrinsic size while keeping responsive
max-width:100%from the global rule.object-fit:initial;to the existing inline style on thenodejs icon
<Image>tags across four getting-started / nextjs-usagepages so the icon isn't subject to the global crop behavior.