Skip to content

fix(toggle-animation): remove collapsed content before animation reset - 21.2.x - #17984

Open
teodosiah wants to merge 1 commit into
21.2.xfrom
thristodorova/fix-17964-21.2.x
Open

teodosiah wants to merge 1 commit into
21.2.xfrom
thristodorova/fix-17964-21.2.x

Conversation

@teodosiah

Copy link
Copy Markdown
Contributor

Closes #17964

Description

Motivation / Context

Type of Change (check all that apply):

  • Bug fix
  • New functionality
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring (no functional changes)
  • Documentation
  • Demos
  • CI/CD
  • Tests
  • Changelog
  • Skills/Agents

Component(s) / Area(s) Affected:

How Has This Been Tested?

  • Unit tests
  • Manual testing
  • Automated e2e tests

Test Configuration:

  • Angular version:
  • Browser(s):
  • OS:

Screenshots / Recordings

Checklist:

  • All relevant labels have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them
  • Accessibility (ARIA, keyboard navigation, focus management) has been verified

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

Real-animation browser validation in a zoneless app is still needed to confirm flicker removal and interrupted transitions across tabs and carousel, since no-op/mock tests verify cleanup ordering but not painting behavior.

No open issues 🎉

What changed in this PR

Addresses collapse flicker in zoneless Angular applications (#17964) by updating component views before shared animation players clear their styles.

Changes:

  • Renders collapsed views synchronously before toggle-player reset and carousel leave-player destruction.
  • Adds regression tests for content removal timing in expansion panels, tree nodes, and both stepper orientations.
  • Documents the user-visible fixes in the changelog.
File Description
projects/​igniteui-angular/​tree/​src/​tree/​tree.spec.ts Verifies node children are removed before collapse-player reset.
projects/​igniteui-angular/​stepper/​src/​stepper/​stepper.component.spec.ts Verifies content removal timing for vertical and horizontal transitions.
projects/​igniteui-angular/​expansion-panel/​src/​expansion-panel/​toggle-animation-component.ts Adds optional synchronous change detection before close-player reset.
projects/​igniteui-angular/​expansion-panel/​src/​expansion-panel/​toggle-animation-component.spec.ts Tests close-completion ordering, open behavior, and destruction handling.
projects/​igniteui-angular/​expansion-panel/​src/​expansion-panel/​expansion-panel.spec.ts Verifies panel body removal before close-player reset.
projects/​igniteui-angular/​carousel/​src/​carousel/​carousel-base.ts Emits leave completion and refreshes the view before destroying the player.
CHANGELOG.md Records the panel, stepper, and tree flicker fixes.

Review effort: Balanced

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants