Skip to content

fix(toggle-animation): remove collapsed content before animation reset - 22.2.x - #17983

Open
teodosiah wants to merge 1 commit into
22.2.xfrom
thristodorova/fix-17964-22.2.x
Open

teodosiah wants to merge 1 commit into
22.2.xfrom
thristodorova/fix-17964-22.2.x

Conversation

@teodosiah

Copy link
Copy Markdown
Contributor

Closes #17964

Description

Motivation / Context

Type of Change (check all that apply):

  • Bug fix
  • New functionality
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring (no functional changes)
  • Documentation
  • Demos
  • CI/CD
  • Tests
  • Changelog
  • Skills/Agents

Component(s) / Area(s) Affected:

How Has This Been Tested?

  • Unit tests
  • Manual testing
  • Automated e2e tests

Test Configuration:

  • Angular version:
  • Browser(s):
  • OS:

Screenshots / Recordings

Checklist:

  • All relevant labels have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them
  • Accessibility (ARIA, keyboard navigation, focus management) has been verified

The expansion panel, tree and stepper removed their collapsed content
only on the next render, after the animation player was reset or
destroyed. The content was then painted in place for a frame, e.g. in
zoneless applications.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@teodosiah
teodosiah requested a review from mddragnev November 13, 2026 13:23
Copilot AI balanced review requested due to automatic review settings November 13, 2026 13:23
@viktorkombov viktorkombov added 💥 status: in-test PRs currently being tested and removed ❌ status: awaiting-test PRs awaiting manual verification labels Nov 13, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

Mocked/no-op tests do not validate the zoneless browser paint-timing fix under real animations, including rapid reversal and synchronous teardown or reentrant completion across carousel, tabs, and stepper.

No open issues 🎉

What changed in this PR

Fixes collapse flicker in zoneless Angular applications by updating rendered content before shared animation cleanup removes animation styles, addressing #17964.

Changes:

  • Runs synchronous change detection before toggle-player reset and carousel leave-player destruction.
  • Adds regression tests for expansion panels, tree nodes, and both stepper orientations, plus toggle completion ordering.
  • Documents the user-visible fixes in the changelog.
File Description
projects/​igniteui-angular/​tree/​src/​tree/​tree.spec.ts Verifies child nodes are removed before collapse-player reset.
projects/​igniteui-angular/​stepper/​src/​stepper/​stepper.component.spec.ts Verifies content removal before animation cleanup in both orientations.
projects/​igniteui-angular/​expansion-panel/​src/​expansion-panel/​toggle-animation-component.ts Updates the owner view synchronously before close-player reset.
projects/​igniteui-angular/​expansion-panel/​src/​expansion-panel/​toggle-animation-component.spec.ts Tests change-detection ordering and post-destruction behavior.
projects/​igniteui-angular/​expansion-panel/​src/​expansion-panel/​expansion-panel.spec.ts Verifies panel-body removal before close-player reset.
projects/​igniteui-angular/​carousel/​src/​carousel/​carousel-base.ts Moves leave completion and view updates ahead of player destruction.
CHANGELOG.md Records expansion-panel, stepper, and tree flicker fixes.

Review effort: Balanced

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants