fix(pivot-grid): prevent selector dimensions list from being clipped when scrolled - #17625
Merged
Merged
Conversation
…when scrolled Closes #17585
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The focused fix addresses the clipping issue; only a non-blocking test-coverage nit remains.
Pull request overview
Fixes pivot-grid selector list clipping in constrained layouts by preventing the filter container and inner list from shrinking.
Changes:
- Adds
flex-shrink: 0to the filter container. - Adds
flex-shrink: 0to the inner list.
File summaries
| File | Summary |
|---|---|
projects/igniteui-angular/grids/pivot-grid/src/themes/_base.scss |
Preserves the selector list’s scrollable height. |
Review details
Suppressed comments (1)
projects/igniteui-angular/grids/pivot-grid/src/themes/_base.scss:120
- This fixes a layout regression, but the existing
pivot-data-selector.spec.tsonly verifies rendered items and filtering; it never renders the selector at a constrained height or verifies that the final list item remains reachable when scrolled. Please add a regression test for the short-selector/scroll-to-end case so a future theme change cannot reintroduce this clipping.
flex-shrink: 0;
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
desig9stein
approved these changes
Sep 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #17585
Description
The pivot grid selector's dimensions/values list (
.igx-pivot-data-selector__filter) did not haveflex-shrink: 0set on itself or on the innerigx-list. When the overall selector panel didn't have enough vertical space (e.g. larger row density, more checked dimensions, shorter grid), the flex column layout shrank the filter container below the height its content needs. Since the container also hasoverflow: hidden, this silently clipped the bottom of the scrollable list, cutting off the last item even when fully scrolled.Added
flex-shrink: 0to.igx-pivot-data-selector__filterand its innerigx-listinprojects/igniteui-angular/grids/pivot-grid/src/themes/_base.scssso the section keeps its natural min/max height and scrolls properly instead of being clipped.Motivation / Context
Pivot grid selector dimensions list does not scroll to the end.
Type of Change (check all that apply):
Component(s) / Area(s) Affected:
Pivot Grid (selector dimensions/values list)
How Has This Been Tested?
Test Configuration: