fix(nav-drawer): preserve single-tap actions on iOS - #17473
Open
viktorkombov wants to merge 3 commits into
Open
Conversation
viktorkombov
added
❌ status: awaiting-test
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes an iOS interaction regression where IgxNavigationDrawerComponent document-level gesture handling could suppress the compatibility click on tap targets (e.g., Navbar/icon-button actions) inside the drawer edge zone, making them appear to require two taps.
Changes:
- Updates
IgxTouchManagerto (a) allowpointerDownto veto tracking and (b) defer pan recognition andtouchmove.preventDefault()until movement exceeds a configurable threshold and matches an axis. - Adjusts Navigation Drawer gesture wiring to qualify edge touches on
pointerDown, then start panning only after ~5px primarily-horizontal movement. - Adds unit coverage for touch-manager gesture arbitration and a Navigation Drawer tap regression scenario.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| projects/igniteui-angular/navigation-drawer/src/navigation-drawer/navigation-drawer.component.ts | Defers drawer pan start until a horizontal pan is recognized; adds pan axis/threshold configuration. |
| projects/igniteui-angular/navigation-drawer/src/navigation-drawer/navigation-drawer.component.spec.ts | Adds regression test ensuring taps in the edge zone don’t start panning or get touchmove prevented. |
| projects/igniteui-angular/core/src/core/touch.ts | Extends touch manager API to support pointerDown veto + pan axis/threshold gating and delays touchmove.preventDefault() until pan start. |
| projects/igniteui-angular/core/src/core/touch.spec.ts | Adds unit tests validating pointerDown veto behavior and pan threshold/axis behavior. |
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.
Suppressed comments (1)
projects/igniteui-angular/core/src/core/touch.ts:296
panThresholdis currently checked against the Euclideandistancebefore applyingpanAxis. WithpanAxis: 'horizontal', a diagonal move like deltaX=4, deltaY=3 hasdistance=5 and will start a pan even though horizontal travel is < 5px. This can still allow small involuntary tap jitter to cross the threshold and reintroduce the iOS click-suppression regression the PR is addressing. Consider applying the threshold on the dominant axis whenpanAxisis constrained.
private _canStartPan(event: IgxGestureEvent): boolean {
if (event.distance < this._panThreshold) {
return false;
}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #17472
Description
Fixes an iOS regression where Navbar and icon-button actions could require two taps while Navigation Drawer gestures were enabled.
The Navigation Drawer now waits for meaningful horizontal movement before claiming the touch gesture and preventing native behavior. This preserves single-tap actions and vertical scrolling while keeping edge-swipe navigation working.
Implementation
The Navigation Drawer previously started tracking a pan immediately on
pointerdown. Its document-leveltouchmovelistener could consequently callpreventDefault()for the small involuntary movement produced during a tap. On iOS, this can suppress the compatibilityclick, making actions appear to require two taps.The fix separates gesture eligibility from gesture recognition:
pointerDownonly checks whether the gesture is eligible, such as starting inside the drawer edge zone.touchmoveis prevented only after the pan has been recognized.Testing
Type of Change (check all that apply):
Component(s) / Area(s) Affected:
How Has This Been Tested?
Test Configuration:
Screenshots / Recordings
Checklist:
feature/README.MDupdates for the feature docsREADME.MDCHANGELOG.MDupdates for newly added functionalityng updatemigrations for the breaking changes (migrations guidelines)