feat(skills): updating all skills - #17433
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refreshes the Ignite UI Angular agent “skills” documentation, primarily by modernizing MCP setup guidance (favoring a one-command igniteui-cli ai-config flow with manual fallbacks) and updating grid/component reference guidance to reduce API guesswork and incorporate newer Angular patterns (e.g., signal-based viewChild usage).
Changes:
- Updated MCP setup instructions across skills to emphasize a “recommended, not required” MCP workflow plus a one-command setup and restart expectations.
- Expanded/adjusted grid guidance (including a new Grid Lite → Grid migration reference) and updated examples to newer Angular query patterns.
- Refined cross-skill routing and component mapping references (e.g., web components for Tile/Dock Manager, related-skill links).
Reviewed changes
Copilot reviewed 24 out of 24 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| skills/igniteui-angular-theming/SKILL.md | Reframes theming MCP as recommended, clarifies palette-token rules, and tightens “file safety” guidance. |
| skills/igniteui-angular-theming/references/mcp-setup.md | Updates MCP setup to one-command ai-config + manual editor-specific fallbacks. |
| skills/igniteui-angular-grids/SKILL.md | Simplifies required workflow and adds a routing row for Grid Lite → Grid migration. |
| skills/igniteui-angular-grids/references/types.md | Updates Grid Lite guidance/examples and clarifies CUSTOM_ELEMENTS_SCHEMA usage expectations. |
| skills/igniteui-angular-grids/references/structure.md | Minor wording update for import guidance. |
| skills/igniteui-angular-grids/references/state.md | Updates examples to signal-based viewChild usage. |
| skills/igniteui-angular-grids/references/grid-migration.md | Adds a dedicated Grid Lite → Grid migration checklist and event/API notes. |
| skills/igniteui-angular-grids/references/features.md | Updates grouping section labeling (but currently introduces a broken TOC anchor link). |
| skills/igniteui-angular-grids/references/editing.md | Minor wording update for the editing decision guidance. |
| skills/igniteui-angular-grids/references/data-operations.md | Minor wording update for import guidance and key rules. |
| skills/igniteui-angular-generate-from-image-design/SKILL.md | Adds MCP-unavailable fallback guidance and expands workflow steps (DV package note, related skills). |
| skills/igniteui-angular-generate-from-image-design/references/component-mapping.md | Updates Tile Manager mapping to web component usage + schema note. |
| skills/igniteui-angular-figma-to-app/SKILL.md | Clarifies workflow wording, tool naming notes, and promotes ai-config for MCP setup. |
| skills/igniteui-angular-figma-to-app/references/validation-patterns.md | Adjusts theming sizing guidance in an example fix workflow. |
| skills/igniteui-angular-figma-to-app/references/mcp-setup.md | Updates MCP verification/tool naming and setup instructions (incl. ai-config guidance). |
| skills/igniteui-angular-figma-to-app/references/figma-component-map.md | Refines component mapping notes and links to layout-manager reference. |
| skills/igniteui-angular-components/SKILL.md | Reframes CLI MCP as recommended and simplifies the required workflow wording. |
| skills/igniteui-angular-components/references/setup.md | Updates entry-point guidance (e.g., Simple Combo, Accordion vs Expansion Panel). |
| skills/igniteui-angular-components/references/mcp-setup.md | Updates CLI MCP setup to one-command ai-config + manual fallbacks. |
| skills/igniteui-angular-components/references/layout.md | Minor wording update (animations/provider reminder). |
| skills/igniteui-angular-components/references/layout-manager.md | Removes a long “user-provided code” example block. |
| skills/igniteui-angular-components/references/feedback.md | Minor wording update (animations/provider reminder). |
| skills/igniteui-angular-components/references/data-display.md | Minor wording update (animations/provider reminder). |
| skills/igniteui-angular-components/references/charts.md | Refreshes the contents section and structure (adds “standalone example” / “common errors” anchors). |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
…angular into skills-update
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 27 out of 27 changed files in this pull request and generated no new comments.
Comments suppressed due to low confidence (2)
skills/igniteui-angular-grids/references/types.md:441
- In this Pivot Grid data example, numeric fields (
UnitPrice,Value,NumberOfUnits) are shown as strings. Pivot aggregations and calculations expect numbers; keeping these as strings can lead to incorrect sorting/aggregation or runtime coercion issues. Use numeric literals for numeric fields.
Product: { Name: 'Clothing', UnitPrice: '12.81' },
Seller: { Name: 'Stanley Brooker', City: 'Seattle' },
Date: '2007-01-01T00:00:00',
Value: '94.27',
NumberOfUnits: '282'
skills/igniteui-angular-grids/references/state.md:101
- This snippet now uses the
viewChildfunction, but the code block doesn’t include theviewChildimport (and also referencesTemplateRef/IgxColumnComponentwithout imports). Since nearby snippets include imports, readers are likely to copy/paste this and hit compile errors. Add the minimal imports inside the code block.
activeTemplate = viewChild.required<TemplateRef<any>>('activeTemplate');
onColumnInit(column: IgxColumnComponent) {
if (column.field === 'IsActive') {
column.bodyTemplate = this.activeTemplate();
ivanvpetrov
requested changes
Jul 29, 2026
ivanvpetrov
left a comment
ivanvpetrov
left a comment
Contributor
There was a problem hiding this comment.
After executing many runs with the changed skills and comparing them to the old ones, my conclusion is:
- There ware recurring errors around moving and grouping in the grid. Suggestions are provided.
- Now the agent relies heavily on MCP guidance which is the right way to go and will get better if we continue improving the MCP tooling and docs. It's terrible if the MCP is not present.
- The change doesn't improve token usage nor generation time
Co-authored-by: ivanvpetrov <110455887+ivanvpetrov@users.noreply.github.com>
Co-authored-by: ivanvpetrov <110455887+ivanvpetrov@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 27 out of 27 changed files in this pull request and generated no new comments.
Comments suppressed due to low confidence (1)
skills/igniteui-angular-grids/SKILL.md:11
- The “routing hub only…no code examples and no API details” statement is contradicted by the same file including selector/component/entry-point tables and other API-specific guidance below. This makes the hub’s contract unclear for readers.
**This file is a routing hub only. It contains no code examples and no API details.** Grid APIs change between releases, so never write component selectors, import paths, method names, or property names from memory — read the relevant reference files first.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 27 out of 27 changed files in this pull request and generated no new comments.
Comments suppressed due to low confidence (2)
skills/igniteui-angular-grids/references/structure.md:173
- The first HTML code block in the Column Moving section is missing its closing fence, which causes the next snippet (and potentially the rest of the file) to render incorrectly.
```html
<igx-grid [moving]="true" ...>
<igx-column field="name" ...></igx-column>
</igx-grid>
skills/igniteui-angular-grids/references/structure.md:167
<igx-column>will be parsed as an HTML tag in Markdown, so the text may not render as intended. Wrap both the element name and the input name in backticks.
This issue also appears on line 169 of the same file.
There is no [movable] input on <igx-column>.
ivanvpetrov
self-requested a review
July 29, 2026 11:26
ivanvpetrov
approved these changes
Jul 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #
Description
Motivation / Context
Type of Change (check all that apply):
Component(s) / Area(s) Affected:
How Has This Been Tested?
Test Configuration:
Screenshots / Recordings
Checklist:
feature/README.MDupdates for the feature docsREADME.MDCHANGELOG.MDupdates for newly added functionalityng updatemigrations for the breaking changes (migrations guidelines)