Skip to content

fix(elements): Ensure ForOF out of bound row gets deleted before moving to opposite side #17238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
skrustev wants to merge 2 commits into
base: 21.1.x
Choose a base branch
from
+18 −5
Open

fix(elements): Ensure ForOF out of bound row gets deleted before moving to opposite side #17238

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1f7b565
fix(elements): Ensure ForOF out of bound row gets deleted before movi…
skrustev Apr 16, 2026
cdf4115
chore(*): Fix tests failing due to wrapped angular.
skrustev Apr 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions projects/igniteui-angular/directives/src/directives/for-of/for_of.directive.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1061,12 +1061,17 @@ export class IgxForOfDirective<T, U extends T[] = T[]> extends IgxForOfToken<T,U

for (let i = start; i < end && this.igxForOf[i] !== undefined; i++) {
const embView = this._embeddedViews.shift();
if (!embView.destroyed) {
if (embView && !embView.destroyed) {
this.scrollFocus(embView.rootNodes.find(node => node.nodeType === Node.ELEMENT_NODE)
|| embView.rootNodes[0].nextElementSibling);
const view = container.detach(0);

// embView and view both refer to the same collections
this.updateTemplateContext(embView.context, i);

// Because in Elements the whole parent div (containing data-index) gets removed (possibly due to being disconnected). In Angular it just gets moved.
// This ensures to update it with the new context and remove it first from DOM because of detach action before inserting it manually.
Comment thread
skrustev marked this conversation as resolved.
view.detectChanges();

container.insert(view);
this._embeddedViews.push(embView);
}
Comment thread
skrustev marked this conversation as resolved.
Expand All @@ -1081,12 +1086,15 @@ export class IgxForOfDirective<T, U extends T[] = T[]> extends IgxForOfToken<T,U
const container = this.dc.instance._vcr as ViewContainerRef;
for (let i = prevIndex - 1; i >= this.state.startIndex && this.igxForOf[i] !== undefined; i--) {
const embView = this._embeddedViews.pop();
if (!embView.destroyed) {
if (embView && !embView.destroyed) {
this.scrollFocus(embView.rootNodes.find(node => node.nodeType === Node.ELEMENT_NODE)
|| embView.rootNodes[0].nextElementSibling);
// embView and view both refer to the same collections
const view = container.detach(container.length - 1);

this.updateTemplateContext(embView.context, i);
view.detectChanges();

container.insert(view, 0);
this._embeddedViews.unshift(embView);
Comment thread
skrustev marked this conversation as resolved.
}
Expand Down
9 changes: 7 additions & 2 deletions projects/igniteui-angular/grids/grid/src/grid.groupby.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { Component, ViewChild, TemplateRef, QueryList } from '@angular/core';
import { Component, ViewChild, TemplateRef, QueryList } from '@angular/core';
import { formatNumber } from '@angular/common'
import { ComponentFixture, fakeAsync, TestBed, tick, waitForAsync } from '@angular/core/testing';
import { By } from '@angular/platform-browser';
Expand Down Expand Up @@ -2615,11 +2615,16 @@ describe('IgxGrid - GroupBy #grid', () => {

// scroll down
grid.verticalScrollContainer.getScroll().scrollTop = 10000;
await wait(100); // Triggers onStable
fix.detectChanges();

dataRows = grid.dataRowList.toArray();
// Workaround for await wait triggering onStable prematurely
(grid as any)._restoreVirtState(dataRows[7]);
await wait(100);
fix.detectChanges();
Comment thread
skrustev marked this conversation as resolved.

// verify rows are scrolled to the right
dataRows = grid.dataRowList.toArray();
dataRows.forEach(dr => {
const virtualization = dr.virtDirRow;
Comment thread
skrustev marked this conversation as resolved.
// should be at last chunk
Expand Down
Loading