Skip to content

feat(splitter): update splitter styles#16909

Merged
simeonoff merged 18 commits intomasterfrom
didimmova/update-splitter
Apr 14, 2026
Merged

feat(splitter): update splitter styles#16909
simeonoff merged 18 commits intomasterfrom
didimmova/update-splitter

Conversation

@didimmova
Copy link
Copy Markdown
Contributor

@didimmova didimmova commented Feb 16, 2026

Related to IgniteUI/igniteui-webcomponents#2022

Aligning the angular splitter to the handoff

@didimmova didimmova linked an issue Feb 16, 2026 that may be closed by this pull request
@didimmova didimmova marked this pull request as ready for review February 17, 2026 07:00
@adrianptrv adrianptrv added ✅ status: verified Applies to PRs that have passed manual verification and removed ❌ status: awaiting-test PRs awaiting manual verification labels Feb 17, 2026
desig9stein
desig9stein previously approved these changes Feb 18, 2026

//splitter-size + borders
$splitter-size: unitless(map.get($theme, 'size')) + 2;
$base-font-size: 16;
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we have a global --ig-base-font-size, why not using it?

border-inline-end: unset;
border-bottom: var-get($theme, 'size') solid transparent;
border-block-end: var-get($theme, 'size') solid transparent;
border-inline-start: var-get($theme, 'size') solid var-get($theme, 'expander-color');
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

var-get($theme, 'size') is used in a lot of places; better store it in a variable

desig9stein
desig9stein previously approved these changes Mar 6, 2026
@didimmova didimmova requested a review from simeonoff March 26, 2026 08:47
Copilot AI review requested due to automatic review settings March 26, 2026 08:47
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the Ignite UI for Angular splitter styling to better align with the referenced handoff/design direction (issue #2022), mainly by adjusting sizing calculations, interaction states (hover/focus/active), and visual treatment of the bar/controls.

Changes:

  • Introduced CSS custom properties to drive indigo splitter sizing/“slim” scaling with runtime calc().
  • Adjusted hover/focus/active visuals (opacity, transitions, focus ring, active colors) for splitter bar, handle, and expanders.
  • Switched focus styling trigger from :focus to :focus-visible on the bar host.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
projects/igniteui-angular/core/src/core/styles/components/splitter/_splitter-theme.scss Refines splitter bar/controls visuals and adds CSS custom properties for sizing + new active-state styling hooks.
projects/igniteui-angular/core/src/core/styles/components/splitter/_splitter-component.scss Updates focus selector to :focus-visible and wires active-state styling via :active selectors.

…tter/_splitter-theme.scss

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@simeonoff simeonoff merged commit d665827 into master Apr 14, 2026
6 checks passed
@simeonoff simeonoff deleted the didimmova/update-splitter branch April 14, 2026 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

✨ themes splitter ✅ status: verified Applies to PRs that have passed manual verification

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Splitter Styles implementation

6 participants