Skip to content

Conversation

@wnvko
Copy link
Contributor

@wnvko wnvko commented Nov 11, 2025

Two things in this PR:

  • fix the way toggle directive shows its target. In open method we set now collapsed to false and call detect changes. In old versions of Angular this updates the related host bindings immediately. As a result we have the target element visible and can measure and position it correctly. In post Ivy versions host bindings are updated on next cycle and to have target element visible we need to wait. This is what the fix is for. More information about this change in Angular here. Manually change the element classes when toggle open is called. This is a workaround and should be replaced with what is described above.
  • make the position strategy of grid toolbar dropdowns auto.
  • fix overlay animation direction change.

Closes #16410

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them

@valadzhov valadzhov added 💥 status: in-test PRs currently being tested ✅ status: verified Applies to PRs that have passed manual verification and removed ❌ status: awaiting-test PRs awaiting manual verification 💥 status: in-test PRs currently being tested labels Nov 12, 2025
@Lipata Lipata merged commit e50b90c into 19.2.x Nov 12, 2025
6 checks passed
@Lipata Lipata deleted the mvenkov/do-not-use-changedetection-to-update-host-bindings-in-toggle-directive-19.2.x branch November 12, 2025 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

grid: toolbar overlay toggle version: 19.2.x ✅ status: verified Applies to PRs that have passed manual verification

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants