Skip to content

Conversation

@adrianptrv
Copy link
Contributor

Closes 1915
Related WC PR: #1929

  • Replaced igx-icon with igc-icon in the WC Tabs demo.
  • Fixed the $border-radius theme parameter so it works correctly.
  • Updated $item-background to apply only to Tab items instead of both Tab items and the Tab Header.

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them

@desig9stein
Copy link
Contributor

THEME: INDIGO
It looks like item-active-background is not used anywhere in the Indigo theme. Its current value also seems incorrect: when I apply it in the expected place, it renders as transparent. I believe it should use the same color as the item-hover-background, since that’s what is currently used in that state.

simeonoff
simeonoff previously approved these changes Nov 10, 2025
@desig9stein desig9stein added 💥 status: in-test PRs currently being tested and removed ❌ status: awaiting-test PRs awaiting manual verification labels Nov 11, 2025
@desig9stein
Copy link
Contributor

desig9stein commented Nov 11, 2025

@adrianptrv, the active background is still not working. I should be able to see the active background on the active tab in the idle state and the active hover background when I hover the active tab.

igx-tabs,
igc-tabs {
    @include css-vars-from-theme(
        $theme: tabs-theme(
            $schema: $schema,

            $item-active-icon-color: green,
            $item-active-hover-icon-color: blue,

            $item-active-color: green,
            $item-active-hover-color: blue,

            $item-active-background: lightblue,
            $item-active-hover-background: darkblue,
        ),
        $name: 'ig-tabs',
    );
}

@desig9stein desig9stein removed the 💥 status: in-test PRs currently being tested label Nov 11, 2025
@desig9stein desig9stein added the ✅ status: verified Applies to PRs that have passed manual verification label Nov 12, 2025
@simeonoff simeonoff merged commit 2d9e881 into 20.1.x Nov 18, 2025
6 checks passed
@simeonoff simeonoff deleted the apetrov/fix-tabs-demo-icon-20.1.x branch November 18, 2025 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

demos styling tabs ✅ status: verified Applies to PRs that have passed manual verification

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants