Skip to content

Auto-fix volume permissions#32

Open
Al2Klimov wants to merge 1 commit into
masterfrom
bugfix/volume-permissions
Open

Auto-fix volume permissions#32
Al2Klimov wants to merge 1 commit into
masterfrom
bugfix/volume-permissions

Conversation

@Al2Klimov
Copy link
Copy Markdown
Member

@Al2Klimov Al2Klimov requested a review from N-o-X October 16, 2020 09:45
@Al2Klimov Al2Klimov force-pushed the bugfix/volume-permissions branch from bdf4d74 to f7cb100 Compare October 21, 2020 14:54
@Al2Klimov
Copy link
Copy Markdown
Member Author

Oh, and please test how this behaves w/ running as root being forbidden by K8s.

@Al2Klimov Al2Klimov force-pushed the bugfix/volume-permissions branch from f7cb100 to d5fb0cf Compare November 3, 2020 15:17
@bartlebi
Copy link
Copy Markdown

Any news?
Same problem on DS220+

@Al2Klimov Al2Klimov requested review from julianbrost and removed request for N-o-X November 17, 2022 11:14
Copy link
Copy Markdown
Member

@julianbrost julianbrost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not like the idea of adding custom suid binaries to the container. Writing them correctly is really hard and this just adds attack surface.

How do other Docker images handle this situation? Why can't the volume be created with the correct permissions? If we conclude that we indeed need to chown as root, this should be done by the entrypoint starting as root and then dropping permissions. This avoids the whole problem that the suid binary might have bugs that could allow to escalate privileges in the container.

@Al2Klimov
Copy link
Copy Markdown
Member Author

We can't do this as some companies disallow root.

@julianbrost
Copy link
Copy Markdown
Member

I doubt they want a random suid binary either. It should be possible to build the entrypoint so that it only does chown if it's started as root. If you don't want that, you start the container with --user icinga and everyone should be fine.

@Al2Klimov
Copy link
Copy Markdown
Member Author

How do you run the container?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants