Conversation
Co-authored-by: Jack Harper <rerpha@users.noreply.github.com>
Tom-Willemsen
left a comment
Tom-Willemsen
left a comment
There was a problem hiding this comment.
Haven't functionally reviewed yet but looks like it should work.
A few nit-pick comments...
| let mut bytes_this_second: usize = 0; | ||
| let mut total_bytes: usize = 0; | ||
| let mut stream = consumer.stream(); | ||
| let mut interval = time::interval(Duration::from_secs(1)); |
There was a problem hiding this comment.
I think it makes sense for this to be configurable (i.e. passed in through command-line flags)
| pub async fn count(topic: BrokerAndTopic) { | ||
| let consumer: StreamConsumer<DefaultConsumerContext> = ClientConfig::new() | ||
| .set("group.id", Uuid::new_v4().to_string()) | ||
| .set("bootstrap.servers", topic.broker()) |
There was a problem hiding this comment.
We should provide some way to pass extra parameters here - either as command line args, in a config file, in env variables, whatever.
Probably extra command line args is easiest.
I'd rather not have to recompile if it turns out we need to specify a queue size or something.
There was a problem hiding this comment.
we'll do this separately for all commands as part of #14
…other ticket) Co-authored-by: Jack Harper <rerpha@users.noreply.github.com>
| } | ||
| _ = interval.tick() => { | ||
| println!("{:.5} Mbit/s (since program start: average {:.5} Mbit/s, {:.5} MB total)", | ||
| bytes_this_second as f64/125000.0, |
There was a problem hiding this comment.
This is only true if interval is 1.
Streaming at ~190 mbit/s with --interval 5:
985.75168 Mbit/s (since program start: average 189.82563 Mbit/s, 9609.95335 MB total)
bytes_this_second needs dividing by interval to be correct here
3 participants
Jack and I's 'Count' function for data streaming rate