Repository navigation
Embed TimeLiner schedules in .nwc files as XML, not CSV - #150
Merged
mahach666 merged 1 commit intoNov 12, 2026
Merged
Conversation
The embedded CSV lost the schedule name, the task hierarchy, progress, node links and multi-line task names. The writer now embeds the existing TimeLiner XML format, and the reader detects XML and still reads the legacy CSV payload. Fixes IOExtend#36 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #36
The TimeLiner stream that
NwcWriterembeds in a.nwcfile held the schedule as CSV. That lost the schedule name, the task hierarchy, progress, node links and multi-line task names.NwcStreamSerializer.BuildTimeLinerStreamnow writes the existing TimeLiner XML format (NwcTimeLinerXmlSerializer) into the same[100][106][count][length][payload]frame.TimeLinerParserlooks at the first non-whitespace character of the payload. It reads XML when that character is<, and the legacy CSV otherwise, so files written by earlier versions still open. A direct (unframed) payload is handled the same way.Compatibility note: earlier NwcIO versions read the embedded payload as CSV, so they won't read a schedule embedded by this version. Standalone CSV import and export are unchanged.
Tests (
TimeLinerTests):TimeLinerSchedule_NwcRoundtrip_PreservesTaskTreeAndMetadata: saves and reopens a document in memory. Checks the schedule name, nested tasks, progress, node links and a multi-line task name. Fails without the src change ("TimeLiner Schedule"instead of"My Schedule").TimeLinerSchedule_OpensLegacyEmbeddedCsv: builds a legacy CSV payload by hand and checks it still opens. It passes before and after.dotnet build NwcIO.slnxsucceeds, andNwcIO.Testspasses locally: 241 passed, and 2 skipped because they need private Navisworks files (.NET 10.0.400 on Windows, withglobal.jsonpinned down to it temporarily; not committed).The change was drafted with OpenAI Codex, then reviewed and verified with Claude Code.
🤖 Generated with Claude Code