Repository navigation
fix: keep same-named materials of different models distinct in GLB - #134
Merged
Merged
Conversation
NwcAssembly.Create deduplicated AllMaterials by name (OrdinalIgnoreCase), so a later model's own material with a shared name (Concrete, Steel) was dropped, and GlbExporter — which looks materials up by reference — silently recoloured that model's meshes with glTF material index 0, an arbitrary unrelated material. Create now dedupes by reference, and GlbExporter grows its material table on demand when a mesh references an unlisted material instead of falling back to index 0 (index 0 remains only for meshes without a material). Closes #82
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NwcAssembly.CreatebuiltAllMaterialswith a by-name (OrdinalIgnoreCase) map, keeping only the first material per name. Federated disciplines routinely ship their own material namedConcrete/Steelwith different colours — the later instances were dropped, and sinceGlbExporterresolves mesh materials by reference, those meshes silently fell back to glTF material index 0 (an arbitrary, unrelated material).Createnow dedupes by reference (HashSet<NwcMaterial>;NwcMaterialhas noEqualsoverride).GlbExportergrows its material table on demand when a mesh references a material the caller did not list, instead of substituting index 0 (index 0 remains only for meshes with no material at all, as the glTF default).Tests
AssemblyGlb_SameNamedMaterialsInDifferentModels_KeepTheirOwnColors: two models, each with its own grey/blueConcreteand a mesh. Asserts both instances surviveAllMaterials, both appear in thematerialsarray, and each mesh's primitive references its own colour's material index.Full suite: 235 passed, 2 skipped.
Closes #82