feat : One Dataset, One Result – Smart Deduplication in Knowledge Space Search ✔#70
Closed
Areeba-Tahir-18 wants to merge 3 commits intoINCF:mainfrom
Closed
feat : One Dataset, One Result – Smart Deduplication in Knowledge Space Search ✔#70Areeba-Tahir-18 wants to merge 3 commits intoINCF:mainfrom
Areeba-Tahir-18 wants to merge 3 commits intoINCF:mainfrom
Conversation
Author
|
Successfully merging this pull request may close these issues. #68 |
Collaborator
|
Closing this PR. The diff accidentally includes the entire Google Cloud SDK directory (1.4M+ file additions) — it appears \ was installed inside the repo directory and everything got staged. The actual deduplication logic (~160 lines in ) is a valid idea, but it's completely buried under hundreds of thousands of unrelated files. Please re-open a clean PR with only the relevant code changes. |
Author
|
Thanks for the review! I see how the diff got bloated with the Google Cloud SDK files. I’ll clean up the PR to include only the deduplication logic and reopen a fresh PR for easier review. I appreciate the guidance! @QuantumByte-01 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR solves issue #68 and introduces a robust deduplication mechanism for the Knowledge Space search tool to ensure cleaner, more accurate search results.
Problem #68
Search results were showing duplicate datasets due to:
Solution
This PR implements:
datasource_id + dataset_idto uniquely identify datasets.Impact of Feature In Real World UseCase
Example
Previously, “Anesthesia EEG Dataset” appeared 3 times from DANDI. Now, only a single clean entry is returned.