Repository navigation
Test 48404: Fix Manual Scoring Filter Toggle-On - #12399
Open
matheuszych wants to merge 1 commit into
Open
matheuszych wants to merge 1 commit into
matheuszych wants to merge 1 commit into
Conversation
See: https://mantis.ilias.de/view.php?id=48404 Toggling the Manual Scoring by question filter back on triggered a Whoops error because required select inputs had no default value. The disabled placeholder option was omitted from the GET request, filter validation failed, and `ilUIFilterService` iterated over null from `getData()`. Set default `withValue(0)` on the "only answered" and "finalized" filter selects so values are always submitted and match the previous no-filter behaviour.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See: https://mantis.ilias.de/view.php?id=48404
Toggling the Manual Scoring by question filter back on triggered a Whoops error because required select inputs had no default value. The disabled placeholder option was omitted from the GET request, filter validation failed, and
ilUIFilterServiceiterated over null fromgetData().Set default
withValue(0)on the "only answered" and "finalized" filter selects so values are always submitted and match the previous no-filter behaviour./cc @thojou