[A11y] fix: Improve wiki title and language for further pdf print#11820
Open
abrahammordev wants to merge 1 commit into
Open
[A11y] fix: Improve wiki title and language for further pdf print#11820abrahammordev wants to merge 1 commit into
abrahammordev wants to merge 1 commit into
Conversation
abrahammordev
added
bugfix
php
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses the accessibility issues reported in the following ticket:
https://mantis.ilias.de/view.php?id=33543
The ticket describes several accessibility problems found in the generated results PDF.
After investigating the current implementation, my understanding is that ILIAS generates the HTML structure used for the print view, while the final PDF generation is handled by the browser. As a result, the output may vary depending on the browser, operating system, and PDF generation engine being used.
The changes proposed in this PR focus on stable document properties that ILIAS can control directly, particularly the document language and title. I have tested the resulting PDF with accessibility validation tools, and these changes reduce the number of reported issues.
@Annett7811, would it be possible for you to review these changes from an accessibility perspective?
@thibsy, I would also appreciate your feedback from the UI perspective, particularly regarding the fact that different browsers or operating systems may interpret and export the same HTML structure differently.
From my point of view, it may be reasonable to address this issue incrementally: first improving the general and consistently controllable aspects of the document, and then investigating more specific issues where the browser-dependent PDF generation allows us to do so.
Thanks,
Abraham