Skip to content

[IMPROVEMENT] User: Improve PHP types in User/Profile#11440

Open
mjansenDatabay wants to merge 1 commit intoILIAS-eLearning:release_11from
mjansenDatabay:improvement/11/usr-profile-types
Open

[IMPROVEMENT] User: Improve PHP types in User/Profile#11440
mjansenDatabay wants to merge 1 commit intoILIAS-eLearning:release_11from
mjansenDatabay:improvement/11/usr-profile-types

Conversation

@mjansenDatabay
Copy link
Copy Markdown
Contributor

This PR improves the type documentation in the
Profile sub-namespace of the "User" component.

Other (relevant) Changes:

  • throw \InvalidArgumentException('This user does not exist.'); (new operator missing)
  • In DatabaseDataRepository::deleteForFieldIdentifier we called manipulateF instead of manipulate
  • CachedConfigurationRepository::buildCustomFieldDefinitions expected a wrong return type from array_search (which will return false and not null in case a value could not be found)

If approved. please pick to trunk as well.

This PR improves the type documentation in the
`Profile` sub-namespace of the "User" component.
@mjansenDatabay mjansenDatabay added improvement php Pull requests that update Php code labels Apr 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement php Pull requests that update Php code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants