mantis 47450 (partly): Release 10 scorm initdata#11402
Open
ingoj wants to merge 5 commits intoILIAS-eLearning:release_10from
Open
mantis 47450 (partly): Release 10 scorm initdata#11402ingoj wants to merge 5 commits intoILIAS-eLearning:release_10from
ingoj wants to merge 5 commits intoILIAS-eLearning:release_10from
Conversation
read xml_base from manifest, resources and each resource. Entries are combined in the order. Some minor code streamlining (put all select statements into variables before launching db queries) Move declare_strict below copyright notice
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix for imported scorm1.2 modules that use xml_base in manifest, resources or any resurce
existing entries are fetched from db and combined (order: manifest, resources, resource) when encoding uriComponent.
some minor code streamlining (pu all select-statements into a variable befor firing the query)
move declare_strict behind copyright statement
codestyle is fixed
This could fix mantis 47450 for the SCORM 1.2 part. SCORM 2004 is not addressed.
The fix may apply to 11 and trunk, too