chore(filter): change the datetime filter.#2711
Draft
sandeshit wants to merge 3 commits intoproject/alert-system-workflowfrom
Draft
chore(filter): change the datetime filter.#2711sandeshit wants to merge 3 commits intoproject/alert-system-workflowfrom
sandeshit wants to merge 3 commits intoproject/alert-system-workflowfrom
Conversation
- Used hash maps to calculate the sum of impacts. - Changed the past event extraction to only include affected total for now.
ranjan-stha
reviewed
Apr 9, 2026
|
|
||
| category = detail.get("category") | ||
| type_ = detail.get("type") | ||
| value = detail.get("value") or 0 |
Contributor
There was a problem hiding this comment.
@sandeshit In pystac-monty side, "0" carries a meaning so when the impact value information is not available, in few of the sources, the "value" might be set to -1 to indicate that there is no information on value (value being int so used -1). So, please control it here as well. If detail.get("value") is -1 also, set it to 0 as you are only calculating the sum per category and type_ basis.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Checklist