Skip to content

add AM v4 api#319

Open
PureMathematics wants to merge 1 commit intoIBM:mainfrom
PureMathematics:add-account-api
Open

add AM v4 api#319
PureMathematics wants to merge 1 commit intoIBM:mainfrom
PureMathematics:add-account-api

Conversation

@PureMathematics
Copy link
Contributor

@PureMathematics PureMathematics commented Feb 11, 2026

PR summary

PR Checklist

Please make sure that your PR fulfills the following requirements:

  • The commit message follows the Angular Commit Message Guidelines.
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Current vs new behavior

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


David seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@PureMathematics PureMathematics force-pushed the add-account-api branch 3 times, most recently from 6c27372 to ee7d447 Compare February 11, 2026 19:34
Signed-off-by: David <David.Lim0305@ibm.com>
Copy link

@rsimsibm2 rsimsibm2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@pyrooka
Copy link
Member

pyrooka commented Feb 12, 2026

A few things are missing from this PR:

  • Missing unit and integration tests
  • No evidence of a clean test run
  • The code is not formatted, thus the builds fail. Run make lint-fix to address this
  • The README is not updated
  • The PR title should be corrected
  • The CLA hasn't been accepted yet. (Or has it?)

See this PR as a reference: #242

Please address each element from the list above to get the PR merged in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants