feat(GlobalTagging): add message field to TagResultsItem#294
Open
stefano-rm wants to merge 1 commit intoIBM:mainfrom
Open
feat(GlobalTagging): add message field to TagResultsItem#294stefano-rm wants to merge 1 commit intoIBM:mainfrom
stefano-rm wants to merge 1 commit intoIBM:mainfrom
Conversation
Add message field to TagResultsItem class to expose detailed error messages from the GhoST Tags API. Changes: - Added message field to TagResultsItem class - Added getMessage() getter method Related: ghost-for-resources swagger PR (merged) Signed-off-by: Stefano Roberto Mollica <stefano.mollica@it.ibm.com>
|
|
mkrudele
reviewed
Feb 13, 2026
mkrudele
left a comment
mkrudele
left a comment
There was a problem hiding this comment.
I don't see unit tests for the case is_error = true, where the message is set.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary
Add optional
messagefield toTagResultsItemclass to expose detailed error messages returned by the GhoST Tags API when tagging operations fail.PR Checklist
Current vs new behavior
Current behavior: When a tagging operation fails, the
TagResultsItemonly containsresourceIdandisErrorfields. Error details are not exposed to SDK users.New behavior: The
TagResultsItemnow includes an optionalmessagefield with a getter method that returns the error message from the API, providing better error diagnostics.Does this PR introduce a breaking change?
Other information
messagefield and its getter method