Conversation
NGrey5
force-pushed
the
fix/long-column-fetch
branch
2 times, most recently
from
August 16, 2026 21:23
948f0d2 to
e027c01
Compare
Signed-off-by: Nick Grey <19329407+NGrey5@users.noreply.github.com>
NGrey5
force-pushed
the
fix/long-column-fetch
branch
from
August 16, 2026 21:26
e027c01 to
c9c0e7b
Compare
kadler
requested changes
Sep 14, 2026
| for (size_t row_index = 0; row_index < data->rows_fetched; row_index++) { | ||
| if (set_position && data->get_data_supports.block && | ||
| data->fetch_size > 1) { | ||
| data->fetch_size > 1 && data->has_long_data) { |
Member
There was a problem hiding this comment.
The order of this is confusing since we're only setting the flag after this check, but this basically just always skips SQLSetPos for the first row. We shouldn't need to call SQLSetPos on the first row and by the second row we'll have set it, so that should work despite being a bit confusing.
Comment on lines
+3463
to
+3464
| // Set the statement data as having long data | ||
| data->has_long_data = true; |
Member
There was a problem hiding this comment.
To reduce confusion, I think this should be moved into bind_buffers wherever we set is_long_data = true. This also means we don't have to set this value for every row, but only once per long data column.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Batched cursor fetches are calling SQLSetPos for columns that contain LONG data even when the queries do not contain LONG data. This causes some drivers to fail as the SQLSetPos call is unnecessary.
These changes mark StatementData with
has_long_dataif any of the columns in it are LONG. The data is then checked ifhas_long_data = truebefore calling SQLSetPos