Skip to content

Remove or harden the test-only deploy ID inventory #1146

Description

@aram356

Description

The test-only DEPLOY_VALIDATED_INTEGRATION_IDS constant in crates/trusted-server-core/src/config.rs duplicates the registered integration builder IDs. Its test currently checks only that no registered builder is missing from the constant; a stale extra ID can remain in the constant without failing. This was identified during the PR #1049 documentation refresh, which added a separate set-equality check, but the redundant inventory and one-directional assertion remain in the current checkout.

Proposed fix

Remove the redundant constant and derive the coverage assertion from a single source of truth, or keep it and make the test compare both sets. Preserve the intended guarantee that every registered integration has deploy validation.

Done when

  • A stale extra ID in the test inventory fails the relevant test, or no duplicated inventory remains.
  • A missing deploy-validated registered builder also fails.
  • The focused config tests pass.

Related

PR #1049 documentation refresh.

Activity

  1. self-assigned this
    on Sep 8, 2026
  2. added
    rustPull requests that update rust code
    and removed
    rustPull requests that update rust code
    on Sep 8, 2026
  3. added theissue type on Sep 10, 2026
  4. changed the issue type fromtoon Oct 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions