Repository navigation
Implement adapter stores or retire dead store manifests #1139
Description
Activity
We need runtime KV on all four adapters for an integration we are building, so we traced how
RuntimeServices::kv_store()is wired at666953a0. Three findings may help the inventory:- Cloudflare and Spin get no KV handle, even when the binding exists. Both adapters read
ctx.kv_store_default(). Only the Fastly adapter implementsHooks::stores(), so EdgeZero builds an empty KV registry on Cloudflare and Spin, and the default handle isNone. The result isUnavailableKvStoreeven withTRUSTED_SERVER_KVbound inwrangler.toml. - Fastly declares the store but does not wire it. The Fastly metadata declares
trusted_server_kv, butRuntimeServicesreceivesUnavailableKvStore. - Declaring the store through
Hooks::stores()would make it mandatory. On Cloudflare, EdgeZero resolves a declared binding as required and fails the request before routing when it is missing. Spin returns an error when a declared label cannot be opened. Either would break every publisher who has not created the namespace or label, including those who never use KV.
No production code calls
kv_store()at the pin, only tests, so wiring it changes no current behavior.We have a branch that opens the store as optional on each adapter. A missing binding keeps today's behavior,
KvError::Unavailable, and requests are still served.- Fastly: opens the linked store at startup.
- Cloudflare: opens the
TRUSTED_SERVER_KVbinding per request. - Spin: opens a dedicated
trusted_server_kvlabel on first use. It never opensdefault, which holds startup config and signing metadata. - Axum: opens a file store when
TRUSTED_SERVER_KV_PATHis set. It runs store operations on the blocking pool, so a slow write cannot hold the request task.
The branch leaves
edgezero.tomland the adapter manifests alone; that decision stays with you, as this issue says. It adds tests for each adapter's selection and open logic and corrects the stale line in the Cloudflare guide. We have also run it onwrangler dev --localandspin upwith the binding present and absent.Would a PR that references this issue, without closing it, be useful? We would rebase it on current
mainfirst.- Cloudflare and Spin get no KV handle, even when the binding exists. Both adapters read
Context
PR #1049's documentation refresh recorded unimplemented adapter stores and dead manifest declarations. That finding is historical. At
666953a0d, Cloudflare and Spin build request-time config and KV adapters from EdgeZero context handles; Spin also loads startup configuration from its default KV-backed config store. Axum reads configuration and secrets from environment variables and has no request-time KV implementation. Cloudflare startup still reads a nestedTRUSTED_SERVER_CONFIGWorker variable, and its admin EC lookup and key-management routes return unsupported responses. The current Cloudflare guide still says its request-time stores are unwired, which disagrees withplatform.rs.Desired outcome
Every declared adapter store has a documented purpose and a tested path from the runtime binding to the feature that consumes it. Unsupported capabilities are accurately described and are not implied by a manifest entry.
Scoped work
edgezero.tomland adapter manifests with the current Cloudflare, Spin, and Axum implementations. For each declared config, KV, and secret store, record its startup and request-time use or its unsupported status.kidvariables are unreachable is no longer sufficient evidence by itself.Done when
Evidence
Source finding: PR #1049 documentation refresh. Current code inspected at
666953a0d: Cloudflare and Spinplatform.rs, Axumplatform.rs, adapter startup loaders,edgezero.toml, anddocs/guide/cloudflare.md. This is an inventory task, not a claim that all PR #1049 gaps still exist.