Show "message from determination" for comments linked to determinations. - #4980
Open
frjo wants to merge 1 commit into
Open
Show "message from determination" for comments linked to determinations.#4980frjo wants to merge 1 commit into
frjo wants to merge 1 commit into
Conversation
frjo
added
Type: Enhancement
Member
Author
|
@wes-otf Is this feature needed at all? It has been around for quite some time but I do not see any real need for it. If you want to see the messaged sent you can always view the determination. Perhaps you can ask OTF staff what they think. If it is useful or just noice. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a determination of type "request for more info" is sent out the message is added as a comment, for auditing I assume.
This PR change the text from "… commented on determination [date]" to "… message from determination [date]". I think this is more clear and correct. This is not a real comment.