Repository navigation
Backend/protocol Completed protocol module for new Backend - #657
Merged
Merged
Conversation
…Endian instead of Big-Endian.
…at require each numeric kind
…d from protection id
…ted Decoding of data.
…oftware into backend/protocol
… measurement in data.rs decoding data function.
…ted Decoding of data.
… measurement in data.rs decoding data function.
…r (due to IO error)
…protections and datapackets
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Merge Request consolidates the protocol module implementation, introducing a unified packet representation (DataOrderPacket), low-level wire serialization/deserialization, and comprehensive module documentation.
Key Updates
Unified DataOrderPacket Representation:
Merged DataPacket and OrderPacket under DataOrderPacket in model::packet, avoiding code duplication while maintaining type aliases (DataPacket, OrderPacket).
Replaced separate data.rs and order.rs files with a unified codec module in packet/data_order.rs.
Wire & Positional Encoding/Decoding:
Header Serialization: Standardized 16-bit packet ID serialization to little-endian (to_le_bytes / from_le_bytes).
Payload Codec: Implemented positional reading/writing against definitions in Index using wire::encode_value and wire::decode_value.
Safety & Validation: Added strict slice length checks (UnexpectedEof), field count validation (WrongFieldCount), and packet kind enforcement (WrongKind).
Documentation & Clean Module Layout:
Added README.md documenting the three-tier architecture (Transport, Packet, Wire), directory layout, and current implementation status.
Re-exported public types and functions cleanly from protocol::mod.
Test Suite: