Skip to content

Move initialitation outside constructor in DualPWM & encoder#642

Open
oganigl wants to merge 11 commits intodevelopmentfrom
init_dual_pwm_encoder
Open

Move initialitation outside constructor in DualPWM & encoder#642
oganigl wants to merge 11 commits intodevelopmentfrom
init_dual_pwm_encoder

Conversation

@oganigl
Copy link
Copy Markdown
Contributor

@oganigl oganigl commented May 4, 2026

No description provided.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 4, 2026

ST-LIB Release Plan

  • Current version: 5.2.0
  • Pending changesets: 6
  • Highest requested bump: minor
  • Next version if merged now: 5.3.0

Pending changes

  • minor add an ethernet connected check (.changesets/add_check_ethernet.md)
  • patch MPUDomain dynamic regions were configured using the linker symbol values instead of their addresses (that is the correct way of using linker symbols). That made non-cached regions cached, and caused harware undefined behaviour. (.changesets/hotfix-mpu-synamic-regions-linker-symbols.md)
  • patch fix pwm channel 4 config in TimerWrapper (.changesets/hotfix-pwm-channel4.md)
  • patch fix prescaler calculation in scheduler (.changesets/hotfix-sched-prescaler.md)
  • minor move initialization outside constructor in PWM, DualPWM, Encoder and InputCapture (.changesets/init_timer.md)
  • minor Small refactor of some spi and timerwrapper functionality (.changesets/refactor-spi-timerwrapper.md)

Comment thread Inc/HALAL/Services/Encoder/Encoder.hpp
Comment thread Inc/HALAL/Services/PWM/DualPWM.hpp
Copy link
Copy Markdown
Contributor

@victor-Lopez25 victor-Lopez25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should also do this in PWM.hpp and InputCapture.hpp for consistency

Comment thread .changesets/init_timer.md Outdated
Copy link
Copy Markdown
Contributor

@victor-Lopez25 victor-Lopez25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last little thing

Comment thread Inc/HALAL/Services/PWM/PWM.hpp
Co-authored-by: Copilot <copilot@github.com>
Copy link
Copy Markdown
Contributor

@victor-Lopez25 victor-Lopez25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants