chore: upgrade Go to 1.27 and align CI checks - #2
Merged
Merged
Conversation
tobyxdd
approved these changes
Sep 21, 2026
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
All reviewed changes are covered by focused tests with no unresolved blocking issues.
Review effort: Lite
Findings: None
What changed in this PR
Upgrades the project to Go 1.27, modernizes APIs, improves shutdown synchronization, and aligns CI checks.
Changes:
- Replaces legacy syntax and manual helpers with modern Go APIs.
- Ensures workers complete before engine shutdown.
- Adds regression tests and updates CI/release tooling.
| File | Description |
|---|---|
ruleset/expr.go |
Uses any in rule data structures. |
ruleset/builtins/geo/matchers_v2geo.go |
Uses slices.SortFunc. |
ruleset/builtins/geo/matchers_v2geo_test.go |
Tests network sorting and matching. |
modifier/udp/dns.go |
Updates modifier argument types. |
modifier/interface.go |
Modernizes modifier interfaces. |
go.mod |
Requires Go 1.27. |
engine/utils.go |
Updates logger argument types. |
engine/tcp.go |
Uses the built-in min. |
engine/interface.go |
Updates logger interface types. |
engine/engine.go |
Waits for workers during shutdown. |
engine/engine_test.go |
Tests worker lifecycle and quotas. |
cmd/root.go |
Updates logger implementations. |
analyzer/udp/internal/quic/payload.go |
Uses modern sorting APIs. |
analyzer/udp/internal/quic/payload_test.go |
Tests QUIC frame assembly. |
analyzer/udp/internal/quic/packet_protector.go |
Uses integer range syntax. |
analyzer/tcp/http.go |
Uses modern header parsing APIs. |
analyzer/tcp/http_test.go |
Tests header values containing colons. |
analyzer/tcp/fet.go |
Uses bits.OnesCount8 and max. |
analyzer/tcp/fet_test.go |
Tests FET metrics. |
analyzer/interface.go |
Modernizes analyzer types. |
.github/workflows/release.yaml |
Builds releases with Go 1.27. |
.github/workflows/check.yaml |
Aligns checks and adds race testing. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AS TITLE