-
Notifications
You must be signed in to change notification settings - Fork 3.3k
feat: BROS-596: Remove the top bar on the labeling stream #8822
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
feat: BROS-596: Remove the top bar on the labeling stream #8822
Conversation
… Labeling Stream. Adapts style of left-side buttons on BottomBar.
✅ Deploy Preview for label-studio-docs-new-theme canceled.
|
✅ Deploy Preview for heartex-docs canceled.
|
✅ Deploy Preview for label-studio-storybook ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for label-studio-playground ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #8822 +/- ##
===========================================
- Coverage 66.65% 57.72% -8.94%
===========================================
Files 829 561 -268
Lines 64782 40590 -24192
Branches 10990 10977 -13
===========================================
- Hits 43183 23429 -19754
+ Misses 21595 17157 -4438
Partials 4 4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
/git merge
|
|
This looks fantastic 🔥 @ricardoantoniocm. One question, with the changes here, what happens with the annotation tabs? Do they remain the same as before but take up the whole row of spacing now? |
|
Thanks @bmartel ! The annotation tabs take up the whole row of spacing now on Quick View and the Review Stream. Minus the View All / Add Annotation buttons. |
|
/git merge
|
|
/git merge
|
…github.com/heartexlabs/label-studio into fb-bros-596/remove-top-bar-labeling-stream
|
/git merge
|
|
/git merge
|
…-top-bar-labeling-stream
… FF_DEV_3873 from BottomBar and CurrentTask.
This pull request refactors and improves the BottomBar component in the editor UI, focusing on layout, style consistency, and user interaction. It moves the
CurrentTaskcomponent to the Bottom Bar, enhances button usability and accessibility, and standardizes spacing and visual separation between controls. The changes also update styles to use theme variables and improve feature flag handling for conditional UI elements.Recordings
Before (LSO)
https://www.loom.com/share/3a6f0e71075143568147b8b1fb55ef92
After (LSO)
https://www.loom.com/share/9626f00290bc4ce58da6dcbdbddbf272
Component and Layout Refactoring:
CurrentTaskcomponent to the BottomBar, which displays the current task ID, history controls, and task counter, with improved feature flag support and conditional rendering. [1] [2] [3] [4]Actionscomponent to use semanticdivcontainers instead ofSpace, grouping action buttons and model actions with clearer separation and updated markup. [1] [2] [3]UI and Style Improvements:
Button and Interaction Enhancements:
Utility and Import Updates:
BemWithSpecificContext) for more flexible class name generation.Icon and Color Consistency: