Skip to content

Use a KGProxy's id in existence queries (fixes #145) - #146

Merged
apdavison merged 1 commit into
HumanBrainProject:masterfrom
apdavison:fix-existence-query-kgproxy
Sep 28, 2026
Merged

apdavison merged 1 commit into
HumanBrainProject:masterfrom
apdavison:fix-existence-query-kgproxy

Conversation

@apdavison

Copy link
Copy Markdown
Member

An unresolved link (KGProxy) in an existence-query property is serialized as {"@id": ...}, which expand_filter() rejects, so exists(), save() and Collection.upload() raise TypeError for objects without a full-URI id.

The proxy's id is now used directly, giving the same query and save-cache key as a resolved node with that id.

Fixes #145

@apdavison apdavison added this to the 0.16 milestone Sep 16, 2026
@apdavison apdavison added the bug Something isn't working label Sep 16, 2026
@apdavison apdavison moved this from Todo to In Progress in fairgraph development Sep 16, 2026
An unresolved link (KGProxy) in an existence-query property was serialized as {"@id": ...}, which expand_filter() rejects, so exists(), save() and Collection.upload() raised TypeError for objects without a full-URI id. The proxy's id is now used directly, giving the same query and save-cache key as a resolved node with that id.
@apdavison
apdavison force-pushed the fix-existence-query-kgproxy branch from 44613cd to ea199ae Compare September 16, 2026 11:31
@apdavison
apdavison merged commit d14985f into HumanBrainProject:master Sep 28, 2026
6 checks passed
@apdavison
apdavison deleted the fix-existence-query-kgproxy branch September 28, 2026 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

Development

Successfully merging this pull request may close these issues.

exists() and save() raise TypeError when an existence-query property holds an unresolved link (KGProxy)

1 participant