Conversation
- Add Aqua as test dependency with all-pass checks (piracy broken=true
for mismatch/mismatch_apertures, which intentionally extend
RegisterMismatchCommon)
- Add missing compat entries: Aqua, CenterIndexedArrays, ImageFiltering,
Libdl, Printf, Test
- Remove Base.isnan piracy for Array{Complex{T}} (method was unused)
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
The vector-argument and old-style Type{T} constructors for CMStorage
were replaced by tuple-based constructors in a prior release.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Replace bare `using X` statements with explicit `using X: X, name, ...` forms for all dependencies. Add ExplicitImports as a test dependency with a regression check via `check_no_implicit_imports`. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
No fields are ever rebound after construction; const makes the immutability explicit and enables compiler optimizations. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- Export highpass (from RegisterCore) which was advertised in the module docstring and tested but never actually re-exported - Add copy(::CMStorage) which deep-copies the internal NanCorrFFTs fields - Delete dead sumsq_finite function (defined but never called) - Add tests for invalid normalization error path and copy(CMStorage) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- Write docstring for `fillfixed!` (was exported but undocumented) - Improve `CMStorage`, `mismatch`, `mismatch!`, `mismatch_apertures`, and `mismatch_apertures!`: fix signature style (4-space indent, imperative mood), add return type annotations, add cross-references, and add `jldoctest` examples to the three primary entry points - Add `Documenter` as a test dependency and wire up `doctest()` in `runtests.jl` Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- README.md: badges (CI, coverage, docs), installation note for HolyLabRegistry, quick-start example - docs/: make.jl, Project.toml, src/index.md (concept overview + 7 jldoctests), src/api.md (full API reference via @docs blocks) - CI.yml: add docs job using julia-docdeploy - makedocs uses modules=[RegisterMismatch, RegisterMismatchCommon, RegisterCore] with checkdocs=:exports and remotes=nothing (upstream pkgs have no git history) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #29 +/- ##
============================================
+ Coverage 87.02% 100.00% +12.97%
============================================
Files 1 1
Lines 131 118 -13
============================================
+ Hits 114 118 +4
+ Misses 17 0 -17 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A full
/freshen-packagepass covering all maintenance steps:isnanpiracyCMStorageconstructorsNanCorrFFTsandCMStoragefieldsconsthighpassexport, addedcopy(CMStorage), reached 100% coveragedocs/with concept overview, 7 verified jldoctests, and complete API reference; addeddocsCI job withjulia-docdeployTest plan
minand1Julia versionsgh-pages(requiresDOCUMENTER_KEYsecret in repo settings)🤖 Generated with Claude Code