Add tests, improve README + docs - #40
Merged
Merged
Conversation
A single support component leaves the per-component construction nothing to accumulate separately, so it returns exactly the global pair bound norm(a)*b. Only the block-diagonal case was covered, where the two differ by a wide margin and an inequality suffices; with one component the bound is attained, and an inequality alone would also pass for a construction that gave up slack it did not have to. The new testset states the agreement two-sided. It also records why the bare `all(s .<= norm(a) .* b)` is not the assertion to write: each sqrt is inflated by 1 + (n+3)*eps so the cover holds despite naive summation, while the right-hand side carries no such margin, so the inequality is false by a few ulps wherever it is tight. The tolerance is that inflation plus the reference's own roundoff, and coverage is asserted separately, since coverage is what the margin exists to deliver. Assisted-by: Claude Opus 5 <noreply@anthropic.com>
Adds: - hints on potential applications to the README - polish on documentation phrasing
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #40 +/- ##
=======================================
Coverage 98.87% 98.87%
=======================================
Files 14 14
Lines 2390 2390
=======================================
Hits 2363 2363
Misses 27 27 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gramcoverfor fully-connected matrices