fix: always treat path parameters as required per OpenAPI 3.x spec#149
Merged
Conversation
) Per OpenAPI 3.x specification §3.3.2, path parameters are always required regardless of whether the `required` field is explicitly set. Normalize `required: true` for all path parameters in `generateValidRootSchema` so that `pickedParameters` and `operationParams.parameters` are consistent with the spec. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…xtures Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…hema tests Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
in: path) are always required — therequiredfield is REQUIRED and its value MUST betrue.normalizePathParametersingenerateValidRootSchema.tsto unconditionally setrequired: trueon all path parameters, covering three locations:components.parameters, PathItem-levelparameters, and operation-levelparameters.required: truein the spec would appear asrequired: undefinedinpickedParametersandoperationParams.parameters, violating the OpenAPI contract.Test plan
generateValidRootSchemacovering: operation-level path params, PathItem-level path params,components.parameterspath params, query params (unchanged), and already-explicitrequired: true(unchanged).test/path-parameter/index.ymlwith path parameters that omitrequired: true.Parameterinterface has non-optional properties for path parameters (id: string, notid?: string), andpickedParameterscarriesrequired: true.pnpm test:vitest40/40,pnpm test:snapshot53/53).Closes #148
🤖 Generated with Claude Code