refactor(core): let Node decide the config module format - #71
Merged
Merged
Conversation
The loader asked Node for the format it chose and overrode only `commonjs-typescript`, instead of walking package.json files and checking the source text for ESM syntax. That removes a duplicated resolution rule, a cache, and a heuristic whose false positive silently switched a CommonJS-authored file to ESM. The rule is now one sentence: TypeScript in the config graph loads as ESM when Node would read it as CommonJS. The loader test covers the commonjs, module, and absent type fields.
Merging needs an explicit instruction from the user for that pull request. Opening one, green checks, and finished-looking work are not instructions. Release pull requests are included.
🦋 Changeset detectedLatest commit: 5082eda The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cleans up the loader change in #69, which worked but did more than it needed to.
packages/cssforge/src/loader.tsno longer walks package.json files, parses them, or guesses the module system from source text. It asks Node for the format Node chose and overrides onlycommonjs-typescript:That drops
packageTypeOf, its cache, and theusesEsmSyntaxregex, whose false positive silently switched a CommonJS-authored file to ESM, so 67 lines become 15 and the rule reads as one sentence: TypeScript in the config graph loads as ESM when Node would read it as CommonJS.Behavior change: a CommonJS-authored
.tsmodule inside a CommonJS package now loads as ESM, matching the documentedexport defaultconfig shape. That is the trade for removing the heuristic, and the changeset says so.Also adds the review rule to AGENTS.md: a pull request is never merged without an explicit instruction for that pull request, release pull requests included.
Verification: the loader test now covers
"type": "commonjs","type": "module", and an absent type field, and fails when the load hook is removed;cssforge:test,typecheck,format,readme-check, andjsr-dry-runpass; the JSR smoke passes with--require-deno; the example browser suite passes 5/5; and a Vite project built against locally packed 0.8.1 plus the plugin emits the tokens under all three type fields.