Skip to content

2026 06 gg fixes #253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
grahamegrieve merged 6 commits into from
Jun 7, 2026
Merged

2026 06 gg fixes #253

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
3d1a8a2
add missing deadChecks
grahamegrieve Jun 6, 2026
272dc33
#239: fix serialising of version in used-fragment
grahamegrieve Jun 6, 2026
43dbd73
#237 error handling unknown code system in exclude
grahamegrieve Jun 6, 2026
515973f
#236 error with inferSystem + a nested-valueSet exclude
grahamegrieve Jun 7, 2026
d430f58
#246 ConceptMap read 404 reports "ValueSet/{id} not found
grahamegrieve Jun 7, 2026
25ed166
#245 Instance reads (GET /{type}/{id}) ignore Accept: application/fhi…
grahamegrieve Jun 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions tx/cs/cs-cs.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1140,6 +1140,7 @@ class FhirCodeSystemProvider extends BaseCSServices {
const allConcepts = this.codeSystem.getAllConcepts();

for (const concept of allConcepts) {
this.opContext.deadCheck('cs:searchFilter');
const rating = this._calculateSearchRating(concept, searchTerm);
if (rating > 0) {
results.add(concept, rating);
Expand Down Expand Up @@ -1285,6 +1286,7 @@ class FhirCodeSystemProvider extends BaseCSServices {

const allCodes = this.codeSystem.getAllCodes();
for (const code of allCodes) {
this.opContext.deadCheck('cs:conceptFilter:is-not-a');
if (!excludeSet.has(code)) {
const concept = this.codeSystem.getConceptByCode(code);
if (concept) {
Expand Down Expand Up @@ -1316,6 +1318,7 @@ class FhirCodeSystemProvider extends BaseCSServices {
const regex = regexUtilities.compile('^' + value + '$');
const allCodes = this.codeSystem.getAllCodes();
for (const code of allCodes) {
this.opContext.deadCheck('cs:conceptFilter:regex');
if (regex.test(code)) {
const concept = this.codeSystem.getConceptByCode(code);
if (concept) {
Expand Down Expand Up @@ -1349,6 +1352,7 @@ class FhirCodeSystemProvider extends BaseCSServices {
}
const descendants = this.codeSystem.getDescendants(ancestorCode);
for (const code of descendants) {
this.opContext.deadCheck('cs:addDescendants');
if (code !== ancestorCode) {
const concept = this.codeSystem.getConceptByCode(code);
if (concept) {
Expand All @@ -1370,6 +1374,7 @@ class FhirCodeSystemProvider extends BaseCSServices {
if (concept) {
const descendants = this.codeSystem.getChildren(parentCode);
for (const code of descendants) {
this.opContext.deadCheck('cs:addChildren');
if (code !== parentCode) { // should not be
const concept = this.codeSystem.getConceptByCode(code);
if (concept) {
Expand All @@ -1393,6 +1398,7 @@ class FhirCodeSystemProvider extends BaseCSServices {

const allCodes = this.codeSystem.getAllCodes();
for (const code of allCodes) {
this.opContext.deadCheck('cs:childExistsFilter');
const hasChildren = this.codeSystem.getChildren(code).length > 0;
if (hasChildren === wantChildren) {
const concept = this.codeSystem.getConceptByCode(code);
Expand All @@ -1419,6 +1425,7 @@ class FhirCodeSystemProvider extends BaseCSServices {
const allConcepts = this.codeSystem.getAllConcepts();

for (const concept of allConcepts) {
this.opContext.deadCheck('cs:propertyFilter');
if (this._conceptMatchesPropertyFilter(concept, propertyDef, op, value)) {
results.add(concept, 0);
}
Expand Down Expand Up @@ -1498,6 +1505,7 @@ class FhirCodeSystemProvider extends BaseCSServices {
const allConcepts = this.codeSystem.getAllConcepts();

for (const concept of allConcepts) {
this.opContext.deadCheck('cs:knownPropertyFilter');
let matches = false;

if (prop === 'notSelectable') {
Expand Down
1 change: 1 addition & 0 deletions tx/cs/cs-loinc.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -947,6 +947,7 @@ class LoincServices extends BaseCSServices {
reject(err);
} else {
for (const row of rows) {
if (this.opContext) this.opContext.deadCheck('loinc:findRegexMatches');
if (regex.test(row[valueColumn])) {
matchingKeys.push(row[keyColumn]);
}
Expand Down
Loading
Loading