size_t for gc globals - #1393
Merged
Merged
Conversation
tobil4sk
reviewed
Sep 9, 2026
|
|
||
| static bool sgAllocInit = 0; | ||
| static bool sgInternalEnable = true; | ||
| static void *sgObject_root = 0; |
Member
There was a problem hiding this comment.
Just to verify this removal, it seems this variable has been unused since: f7d27a4
| void **stack = *(void ***)(&tmp); | ||
| sgObject_root = stack[0]; | ||
|
|
||
| //GCLOG("__root pointer %p\n", sgObject_root); |
Member
There was a problem hiding this comment.
We can get rid of this commented out log now, since sgObject_root is gone
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates those global
sgvariables to besize_t. I think looking at switching QuickVec to beingsize_tbased will be the thing to tackle next as there's lots of questionable implicit conversions going on withsizeand the likes.