Avoid adding fastcall attribute on linux aarch64#1282
Open
tobil4sk wants to merge 1 commit intoHaxeFoundation:masterfrom
Open
Avoid adding fastcall attribute on linux aarch64#1282tobil4sk wants to merge 1 commit intoHaxeFoundation:masterfrom
tobil4sk wants to merge 1 commit intoHaxeFoundation:masterfrom
Conversation
tobil4sk
force-pushed
the
fix/linux-aarch64-fastcall-warning
branch
from
378eda1 to
4be2564
Compare
fastcall should only be added for 32 bit x86, as explained in the
comment. On some linux aarch64 compilers, none of the existing defines
are set, and __aarch64__ is set instead. Adding this avoids warnings
like:
```
In file included from /home/runner/haxelib/hxcpp/git/include/hxcpp.h:336:
/home/runner/haxelib/hxcpp/git/include/hx/Object.h:60:65: warning: ‘fastcall’ attribute directive ignored [-Wattributes]
60 | typedef void (CPPIA_CALL *StackExecute)(struct StackContext *ctx);
| ^
In file included from /home/runner/haxelib/hxcpp/git/include/hxcpp.h:336:
/home/runner/haxelib/hxcpp/git/include/hx/Object.h:60:65: warning: ‘fastcall’ attribute directive ignored [-Wattributes]
60 | typedef void (CPPIA_CALL *StackExecute)(struct StackContext *ctx);
| ^
```
tobil4sk
force-pushed
the
fix/linux-aarch64-fastcall-warning
branch
from
4be2564 to
047c0e5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fastcall should only be added for 32 bit x86, as explained in the comment. On some linux aarch64 compilers, none of the existing defines are set, and
__aarch64__is set instead. Adding this avoids warnings like: