[fix] Socket: Fix stale indexes and surface close/error reliably in _hx_std_socket_poll_events#1252
Open
dimensionscape wants to merge 2 commits intoHaxeFoundation:masterfrom
Open
[fix] Socket: Fix stale indexes and surface close/error reliably in _hx_std_socket_poll_events#1252dimensionscape wants to merge 2 commits intoHaxeFoundation:masterfrom
dimensionscape wants to merge 2 commits intoHaxeFoundation:masterfrom
Conversation
…ents` on error/empty sets Previously, `_hx_std_socket_poll_events` could exit early on `select()/poll()` errors without resetting the ready index arrays. This left stale values in `p->ridx/p->widx`, causing incorrect results when the socket set was empty or when sockets were removed. In Haxe this manifested as phantom entries (e.g. index "1" still marked ready after deregistration, or `poll([])` returning `[null]`). This change ensures `p->ridx[0]` and `p->widx[0]` are always initialized to `-1` at function entry, and remain consistent even if `select()/poll()` returns an error. With this fix, empty socket sets no longer yield spurious ready indexes, and poll() on an empty registry correctly returns `[]` without mutating the input array.
Windows: pass/handle exceptfds in select() and on SOCKET_ERROR surface current read fds for cleanup. POSIX: include POLLERR|POLLNVAL in readiness. Ensures peer FIN/RST/error is observed by default once-per-frame events(0) loops without scanning or keepalives as it should.
12 tasks
Contributor
Author
|
This is actually a kind of important fix for me personally as my framework is broken without it. If it's helpful, I can demonstrate a sample case that it resolves. @Simn But, for simplicity, I think we can agree that |
Member
|
Would it be feasible to add some tests? E.g. like here: Line 483 in 0b59d98 |
Contributor
Author
|
Yeah I will add tests for it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains two related fixes in
_hx_std_socket_poll_eventsto makepolling safer and more consistent:
Clear ridx/widx on entry and early return
Prevents stale values when polling with empty registries or when
select()/poll() errors out. Previously this could result in phantom
indexes or poll([]) returning [null].
Surface close/error conditions reliably
exceptfdsset to detect errorsand connection resets. On
SOCKET_ERROR, all current read fds aresurfaced so userland can clean up.
POLLERR | POLLNVALalongsidePOLLIN/HUPandPOLLOUT/HUPso teardown/error conditions are not missed.Together these changes ensure that:
userland can detect EOF and deregister them.