Don't define _CRT_SECURE_NO_DEPRECATE on non-windows targets.#1160
Open
MAJigsaw77 wants to merge 10 commits intoHaxeFoundation:masterfrom
Open
Don't define _CRT_SECURE_NO_DEPRECATE on non-windows targets.#1160MAJigsaw77 wants to merge 10 commits intoHaxeFoundation:masterfrom
_CRT_SECURE_NO_DEPRECATE on non-windows targets.#1160MAJigsaw77 wants to merge 10 commits intoHaxeFoundation:masterfrom
Conversation
Member
|
Here is a page from the microsoft docs which mentions the define, confirming that it's windows-specific: https://github.com/MicrosoftDocs/cpp-docs/blob/25815cbe0dd6bae018890dd85eb10e5e5feece8e/docs/c-runtime-library/security-features-in-the-crt.md |
tobil4sk
approved these changes
Aug 2, 2025
Member
|
I noticed, the msvc toolchain already adds this flag for all msvc builds: hxcpp/toolchain/msvc-toolchain.xml Line 104 in 1618253 So I wonder if it's safe to remove it from |
Contributor
Author
Perhaps, if it doesnt break anything. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.