Skip to content

Don't define _CRT_SECURE_NO_DEPRECATE on non-windows targets.#1160

Open
MAJigsaw77 wants to merge 10 commits intoHaxeFoundation:masterfrom
MAJigsaw77:patch-3
Open

Don't define _CRT_SECURE_NO_DEPRECATE on non-windows targets.#1160
MAJigsaw77 wants to merge 10 commits intoHaxeFoundation:masterfrom
MAJigsaw77:patch-3

Conversation

@MAJigsaw77
Copy link
Contributor

No description provided.

@tobil4sk
Copy link
Member

tobil4sk commented Aug 2, 2025

Here is a page from the microsoft docs which mentions the define, confirming that it's windows-specific: https://github.com/MicrosoftDocs/cpp-docs/blob/25815cbe0dd6bae018890dd85eb10e5e5feece8e/docs/c-runtime-library/security-features-in-the-crt.md

@tobil4sk
Copy link
Member

tobil4sk commented Sep 8, 2025

I noticed, the msvc toolchain already adds this flag for all msvc builds:

<flag value="-D_CRT_SECURE_NO_DEPRECATE"/>

So I wonder if it's safe to remove it from haxe-target.xml?

@MAJigsaw77
Copy link
Contributor Author

I noticed, the msvc toolchain already adds this flag for all msvc builds:

<flag value="-D_CRT_SECURE_NO_DEPRECATE"/>

So I wonder if it's safe to remove it from haxe-target.xml?

Perhaps, if it doesnt break anything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants